fix(react): close link popover on submit in Static Formatting Toolbar… #1997
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@dsriva03 is attempting to deploy a commit to the TypeCell Team on Vercel. A member of the Team first needs to authorize it. |
nperez0111
reviewed
Sep 11, 2025
Comment on lines
135
to
137
| update(url); | ||
| setOpened(false); | ||
| editor.focus(); |
Contributor
There was a problem hiding this comment.
Shouldn't this just be within the update callback?
nperez0111
requested changes
Sep 11, 2025
Contributor
nperez0111
left a comment
nperez0111
left a comment
There was a problem hiding this comment.
It's really just one line to add
Contributor
Author
|
gotcha! just moved setOpened(false) into update as suggested 👍 |
Contributor
|
Thanks for this fix! @dsriva03, appreciate it! |
Contributor
Author
|
Happy to help! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1696
Before
In the Static Formatting Toolbar, after inserting a link the popover remained open.
After
After submitting a URL and pressing Enter, the popover closes and focus returns to the editor.
Change
CreateLinkButton.tsx: wrapeditLinkto callsetOpened(false)andeditor.focus()after applying the link.Manual QA
Note: The demo recording is from my local docs environment (with some examples disabled for testing).
The change itself is isolated to
CreateLinkButton.tsx, no toolbar layout or styling changes were made.